fix: prevent loading animation interval from running indefinitely #4953
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add loadAnimationIntervalId property to track the setInterval ID - Add stopLoadAnimation() method to clear the interval and hide the container - Call stopLoadAnimation() when blocks finish loading Previously, the loading message animation (which cycles through fun messages like 'Catching mice', 'Tuning string instruments', etc.) would continue running every 2 seconds forever in the background, even after loading completed. This wasted CPU cycles and could cause subtle UI glitches. Now the interval is properly cleared when loading completes.
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the loading message animation (which cycles through fun messages like 'Catching mice', 'Tuning string instruments', etc.) would continue running every 2 seconds forever in the background, even after loading completed. This wasted CPU cycles and could cause subtle UI glitches.
Now the interval is properly cleared when loading completes.