Add integration tests for PitchBlocks#4956
Open
AviraL0013 wants to merge 2 commits intosugarlabs:masterfrom
Open
Add integration tests for PitchBlocks#4956AviraL0013 wants to merge 2 commits intosugarlabs:masterfrom
AviraL0013 wants to merge 2 commits intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Member
|
Overall, this looks good, but it would be good to add to the current PitchBlocks.tests.js instead of adding another file. |
Member
|
Apologies for the very very tardy review. I had been leaving reviews of tests to other community members. |
Contributor
|
@AviraL0013 Resolve ES Lint errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds integration-style tests for PitchBlocks, following the same mocking and execution strategy used in existing block tests.
PitchBlocks depend heavily on the Logo runtime and Singer state, so tests validate observable behavior using mocked execution contexts rather than isolated units.
To support Jest-based testing, this PR also adds a guarded CommonJS export for setupPitchBlocks, consistent with other block modules in the codebase. The export is wrapped to avoid any impact in browser environments.
No runtime behavior is changed.
@walterbender Could you please review this?