Rhythm Maker: Replace Number Input with Pie Menu#4998
Rhythm Maker: Replace Number Input with Pie Menu#4998walterbender merged 5 commits intosugarlabs:masterfrom
Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
The pie menu works well, but you should still be able to type in a number. Otherwise you are restricted to the pie menu choices. |
|
@walterbender i have enabled the type functionality for the number field Screen.Recording.2026-01-11.at.10.34.59.PM.mov |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
How did .DS_store get added to this PR? |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@walterbender the .DS_store file is a system file created by MAC OS, and i have moved the pie menu code to js/piemenus.js |
|
Not sure how or when .DS_store got added but we should remove it here and add it to .gitignore |
do you want me to add it to .gitignore? |
|
Yes please. That way it will trigger a warning if someone inadvertently tries to add it. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
i have added them into .gitignore |
* Added a Pie menu for Rhythm Maker * Remove accidentally committed .DS_Store files * Enable Type Functionality for Rhythm Maker * Moved the Piemenu code to piemenus.js * Ignore macOS .DS_Store files
2 participants
This PR replaces the text based number input in the Rhythm Maker widget with a visual pie menu for selecting rhythm subdivisions.
In beginner mode, the menu shows 2, 3, 4. In advanced mode, it shows 2, 3, 4, 5, 7. The menu opens when clicking the number, supports both mouse and touch input, and updates the value immediately.
Screenshots in beginner and advanced modes:
closes #4273