[Refactor] Improve screen recording feature

[farhan-momin]

This PR resolves #4505

Changes Made to the functionality

• Screen sharing requires permission only once for recording multiple clips.
• Stop sharing does not need to be clicked every time for a recording.

Working of Record feature after changes

• Clicking on Record button MB asks for screen share permission.
• Allowing permission shares the current tab with MB and starts recording.
• Multiple clips can be recorded with record button.
• After stop sharing permission, above process can repeat.

Past Discussion about these changes can be found at PR #4506

working_after_changes_2.webm

[github-actions]

✅ All Jest tests passed! This PR is ready to merge.

[farhan-momin]

@pikurasa please review

[kartikktripathi]

Hey @farhan-momin, thanks for working on this. I have one concern regarding screen recording permissions.
Would it be better to always prompt the user for permission (including browser audio) each time instead of reusing a previous choice? Also, I think the recording flow should explicitly stop screen sharing once the recording ends, rather than relying on the user to manually click “Stop sharing.”

From a privacy and UX standpoint, automatically releasing screen access after recording finishes feels like the safer and more expected behaviour.

[farhan-momin]

Hello @kartikktripathi, I appreciate your concern. This is the workflow I had in mind for the functionality:

User Clicks on record -> Allow screen sharing -> Can record multiple screen recordings -> Stops sharing when done

When user wants a recording, they might want to re-record multiple times to get it right. So instead of allowing permission every time, they can stop sharing screen when recording is done.

[kartikktripathi]

I agree with your take on this as well, and I also believe that it should be the right approach towards this feature. I want to approve your contribution. Thanks for contributing to this!

[kartikktripathi]

Tested locally, works well, LGTM.

[walterbender]

@pikurasa I would like your opinion on this one.

[farhan-momin]

@walterbender If there are any changes needed please let me know

[walterbender]

I am waiting for @pikurasa 's opinion from the POV of a classroom teacher.