Update abc.js tests to achieve ~99% code coverage#5137
Merged
omsuneri merged 2 commits intosugarlabs:masterfrom Jan 12, 2026
Merged
Update abc.js tests to achieve ~99% code coverage#5137omsuneri merged 2 commits intosugarlabs:masterfrom
omsuneri merged 2 commits intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refines the unit tests in
js/__tests__/abc.test.jsto accurately reflect the ABC notation generation logic. These improvements have resolved expectation mismatches and significantly boosted test coverage.Key Changes
abc.js.Impact
Ensures
abc.jsis thoroughly tested and the test suite accurately validates the internal logic for complex musical notation.Fixes
Closes #5136