chore: improve loading text contrast in light mode#5140
Merged
walterbender merged 1 commit intosugarlabs:masterfrom Jan 18, 2026
Merged
chore: improve loading text contrast in light mode#5140walterbender merged 1 commit intosugarlabs:masterfrom
walterbender merged 1 commit intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
Author
Contributor
Author
|
@walterbender please review and merge. |
Member
|
Did you test in dark mode too? It is OK? |
Contributor
Author
|
@walterbender Yes, It is clearly visible in both dark and light mode. |
021nirav-blip
pushed a commit
to 021nirav-blip/musicblocks
that referenced
this pull request
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5139
This PR improves the readability of the loading screen text in light mode by setting its color to
#333.Previously, the loading text used a very light gray that had low contrast against the white background, making it harder to read. The color
#333is already widely used throughout the Music Blocks codebase for primary text, so using it here keeps the UI visually consistent while significantly improving contrast and accessibility.The change was made in the loading text element:
No functionality is affected — this is a small UI polish to improve clarity and user experience.
