Skip to content

Enhance observability in core modules via descriptive error handling #5195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saishmungase wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −14
Open

Enhance observability in core modules via descriptive error handling #5195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions js/utils/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,11 +696,9 @@ const processPluginData = (activity, pluginData, pluginSource) => {
let obj;
try {
obj = JSON.parse(pluginData);
} catch (e) {
// eslint-disable-next-line no-console
console.log(pluginData);
// eslint-disable-next-line no-console
console.log(e);
} catch (error) {
console.error(`PluginProcessor: Failed to parse plugin data from source "${pluginSource}":`, error);
console.debug("Malformed plugin data:", pluginData);
return null;
}
// Create a palette entry.
Expand Down
10 changes: 4 additions & 6 deletions planet/js/ProjectStorage.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions planet/js/Publisher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,9 +304,8 @@ class Publisher {
parseProject(tb) {
try {
tb = JSON.parse(tb);
} catch (e) {
// eslint-disable-next-line no-console
console.log(e);
} catch (error) {
console.error("Publisher: Failed to parse project data for keyword extraction.", error);
return "";
}

Expand Down
Loading