test: add tests for js/widgets/statistics.js#5222
test: add tests for js/widgets/statistics.js#5222Om-A-osc wants to merge 3 commits intosugarlabs:masterfrom
js/widgets/statistics.js#5222Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@omsuneri @walterbender Could you please have a look when convenient? |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@walterbender Whenever you have time, I’d appreciate any feedback on this PR. |
|
Sorry about being slow to review this. I think it looks good over all. I do think that since there is another PR, #4972, which covers some of the same ground, it would make sense for you to build upon that initial effort. |
|
@Om-A-osc resolve merge conflicts. |
Om-A-osc
force-pushed
the
test/statistics-jest
branch
from
6488c50 to
e8a9e7e
Compare
|
✅ All Jest tests passed! This PR is ready to merge. |
@walterbender @vanshika2720 Done! |
|
I think you need to do a rebase before applying your changes. Lots of things are unintentionally removed here. |
Om-A-osc
force-pushed
the
test/statistics-jest
branch
from
e8a9e7e to
3cfa87d
Compare
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@walterbender I guess it should be ready to merge now. I have rebased and added hardening tests on top of existing code. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@walterbender @omsuneri Please have a look guys. |
3 participants
Resolves #5221
Add Jest tests for
statistics.jswidgetThis PR adds unit tests for the
StatsWindowwidget (js/widgets/statistics.js).Highlights:
statistics.jsfrom 0% to 100%onclose,onmaximize)doAnalytics()behavior, including analytics execution, chart creation, and DOM updatesdisplayInfo()to ensure statistics are rendered correctlyThis is a test-only change and does not modify runtime behavior.
