fix: resolve ReferenceError for undefined lang in loader.js#5268
Closed
Rohit-rk07 wants to merge 3 commits intosugarlabs:masterfrom
Closed
fix: resolve ReferenceError for undefined lang in loader.js#5268Rohit-rk07 wants to merge 3 commits intosugarlabs:masterfrom
Rohit-rk07 wants to merge 3 commits intosugarlabs:masterfrom
Conversation
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
- Fix typo: twewn -> tween in RequireJS paths - Refactor i18n initialization flow - Remove redundant language change logic - Consolidate lang variable inside main() function - Update tests to match new implementation Fixes sugarlabs#5197
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
Author
|
@omsuneri @haroon10725 @walterbender Plz review the chnages. |
Contributor
|
@Rohit-rk07 removing changeLanguage() and deleting its related tests goes beyond the minimal fix. Please confirm this behavioral change is intentional and does not affect dynamic language switching. Also resolve merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: ReferenceError - lang is not defined in loader.js
Fixes #5197
Changes
twewn→tweenchangeLanguage()calllangvariable insidemain()functionlngparameterBenefits
ReferenceError: lang is not definederrorTesting