UI: Fix help widget sidebar colours in dark mode#5276
UI: Fix help widget sidebar colours in dark mode#5276walterbender merged 4 commits intosugarlabs:masterfrom
Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
|
Hey @walterbender, pinging for the review, no rush. I believe the change can provide users with a better help widget UI. Thanks! |
56a311d to
67fe8cb
Compare
|
✅ All Jest tests passed! This PR is ready to merge. |
|
I see lots of formatting changes but where is the actual change you made that impacts the side colors? Also, please resolve the conflicts. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
It seems like a change was made by another PR that affected the colour of the main body of the widget in dark mode. I will check the changes responsible for the same, make the changes that are required and get back to you. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
I found the PR that caused a conflict. When #5303 was merged, it focused on the main body of the widget and not the sidebars, causing you to see a difference in the colours, which looks odd, I agree. When I raised this PR, I had the idea of keeping the body colour constant, totally, for the help widget, which is why I commented the correct line, but if #5303 keeps |
|
✅ All Jest tests passed! This PR is ready to merge. |
* fixed help widget color * color change


Summary
When PR #5165 was merged, it unintentionally affected the help widget sidebars in dark mode, causing them to render with an inconsistent colour compared to the rest of the UI. This PR fixes that issue by restoring the correct sidebar styling in dark mode, ensuring visual consistency across the help widget.
Before:

After:

Note