Skip to content

UI: Fix help widget sidebar colours in dark mode#5276

Merged
walterbender merged 4 commits intosugarlabs:masterfrom
kartikktripathi:helpfix
Jan 31, 2026
Merged

UI: Fix help widget sidebar colours in dark mode#5276
walterbender merged 4 commits intosugarlabs:masterfrom
kartikktripathi:helpfix

Conversation

@kartikktripathi
Copy link
Contributor

Summary

When PR #5165 was merged, it unintentionally affected the help widget sidebars in dark mode, causing them to render with an inconsistent colour compared to the rest of the UI. This PR fixes that issue by restoring the correct sidebar styling in dark mode, ensuring visual consistency across the help widget.

Before:
Screenshot 2026-01-22 at 12 48 06 AM

After:
Screenshot 2026-01-22 at 12 50 27 AM

Note

  1. No functional changes
  2. Styling fix only

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@kartikktripathi
Copy link
Contributor Author

Hey @walterbender, pinging for the review, no rush. I believe the change can provide users with a better help widget UI. Thanks!

@kartikktripathi kartikktripathi deleted the helpfix branch January 30, 2026 16:52
@kartikktripathi kartikktripathi restored the helpfix branch January 30, 2026 16:53
@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@walterbender
Copy link
Member

I see lots of formatting changes but where is the actual change you made that impacts the side colors? Also, please resolve the conflicts.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@walterbender
Copy link
Member

I am still seeing this:

image

@kartikktripathi
Copy link
Contributor Author

It seems like a change was made by another PR that affected the colour of the main body of the widget in dark mode. I will check the changes responsible for the same, make the changes that are required and get back to you.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@kartikktripathi
Copy link
Contributor Author

I found the PR that caused a conflict. When #5303 was merged, it focused on the main body of the widget and not the sidebars, causing you to see a difference in the colours, which looks odd, I agree. When I raised this PR, I had the idea of keeping the body colour constant, totally, for the help widget, which is why I commented the correct line, but if #5303 keeps #505050 as the primary background colour of the help widget for visibility (which is important too, I agree), the sidebars should be of the same color as the background colour of the main body.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@kartikktripathi
Copy link
Contributor Author

I have tested the finalised changes by me; it looks good to me, visibility is fine, and there is a constant colour across the widget too. Thanks!
Screenshot 2026-02-01 at 3 32 25 AM

@walterbender walterbender merged commit bfdfa23 into sugarlabs:master Jan 31, 2026
6 checks passed
@kartikktripathi kartikktripathi deleted the helpfix branch February 1, 2026 05:50
vanshika2720 pushed a commit to vanshika2720/musicblocks that referenced this pull request Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants