Fix: improve accessibility for toolbar and menu buttons#5280
Fix: improve accessibility for toolbar and menu buttons#5280nishtha-agarwal-211 wants to merge 4 commits intosugarlabs:masterfrom
Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
|
hey, i have tested this PR and the keyboard navigations are not working. Not sure about the screen reader. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
Thanks for testing and pointing this out! I’ve pushed a follow-up commit that enables proper keyboard activation using Enter and Space for toolbar and menu buttons. I’ve tested the changes using Tab navigation and verified that buttons are now focusable and activatable via keyboard. Please let me know if you’re able to re-test or if any additional accessibility improvements are needed. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@nishtha-agarwal-211 Copy of #5114 .Close duplicate PR's so maintainer can review easily |
|
Thank you for pointing it out. |
Fixes: #5113
Summary
Improve accessibility for toolbar and menu buttons
Description
This PR improves the accessibility of toolbar and menu buttons in
index.htmlso they work better with keyboard navigation and screen readers.The changes are small and focused only on accessibility. There are no visual or behavior changes.
Changes Made
role="button"to interactive elements (56 total) withouthrefattributestabindex="0"to make all toolbar and menu buttons keyboard-focusablearia-labelattributes to 30 icon-only buttons for better screen reader announcementsaria-disabled="true"to the disabled Planet icon buttonAffected Elements
Testing
Result
No JavaScript, CSS, or structural HTML changes were made.