Skip to content

fixed visiblity issues#5287

Closed
kh-ub-ayb wants to merge 1 commit intosugarlabs:masterfrom
kh-ub-ayb:visiblity-issue
Closed

fixed visiblity issues#5287
kh-ub-ayb wants to merge 1 commit intosugarlabs:masterfrom
kh-ub-ayb:visiblity-issue

Conversation

@kh-ub-ayb
Copy link
Contributor

@kh-ub-ayb kh-ub-ayb commented Jan 22, 2026

Summary

This PR improves the visibility of the error notification ("Cannot load project from the file. Please check the file type.") in dark mode

Related Issue

Fixes: #5286

Screenshot

BEFORE:
image

AFTER:
image

@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2026

✅ All Jest tests passed! This PR is ready to merge.

@kh-ub-ayb
Copy link
Contributor Author

kh-ub-ayb commented Jan 22, 2026 •
edited
Loading

@omsuneri @haroon10725 @walterbender plz review

kh-ub-ayb
kh-ub-ayb commented Jan 22, 2026
View reviewed changes
css/activities.css
background-color: pink;
border: 2px solid red;
background-color: pink;
color: #000000;
Copy link
Contributor Author

@kh-ub-ayb kh-ub-ayb Jan 22, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is the only change made in code .
All other changes in this file were introduced automatically after running the following formatting command:
npx prettier --write css/activities.css
If these formatting changes are not preferred in this PR i can revert the formatting-only changes and open a separate PR focused solely on formatting

Copy link
Contributor

@haroon10725 haroon10725 Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this change only.

@7se7en72025
Copy link
Contributor

7se7en72025 commented Jan 23, 2026

sry, but i feel they ain't center aligned @kh-ub-ayb

@kh-ub-ayb
Copy link
Contributor Author

kh-ub-ayb commented Jan 23, 2026

sry, but i feel they ain't center aligned @kh-ub-ayb

prettier --check only checks formatting and doesn’t affect UI alignment.
This PR only updates the text color to improve visibility.

@haroon10725
Copy link
Contributor

haroon10725 commented Jan 23, 2026

@kh-ub-ayb I haven't tested the PR yet. Please remove the prettier check.

@kh-ub-ayb
Copy link
Contributor Author

kh-ub-ayb commented Jan 23, 2026

@kh-ub-ayb I haven't tested the PR yet. Please remove the prettier check.

ok sure , i will rise a new pr without prettier check

@kh-ub-ayb kh-ub-ayb closed this Jan 23, 2026
@kh-ub-ayb kh-ub-ayb deleted the visiblity-issue branch January 23, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haroon10725 haroon10725 haroon10725 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix Dark Mode Visibility

3 participants

@kh-ub-ayb @7se7en72025 @haroon10725