Fix #5286: Improved contrast for error notifications in Dark ModeFix/dark mode notification contrast#5293
Open
Ronak-si wants to merge 2 commits intosugarlabs:masterfrom
Open
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
@Ronak-si Lots of unrelated changes..remove them |
Ronak-si
force-pushed
the
fix/dark-mode-notification-contrast
branch
from
e7e5c75 to
875bb0c
Compare
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Author
|
"Hi @vanshika2720 , I have removed all the unrelated test and refactoring files as requested, resolved the CSS merge conflicts, and fixed the PR category. The PR now strictly contains the 14 lines for the dark mode contrast fix and all automated checks are passing. It is ready for your review!" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: improve contrast for error notifications in dark mode
Changes
.toastand.popupMsgclasses within the.darktheme inthemes.css.Fixes #5286
PR Category