Fix navigation arrow overlap in About dialog#5294
Fix navigation arrow overlap in About dialog#5294nishtha-agarwal-211 wants to merge 1 commit intosugarlabs:masterfrom
Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
|
Not reviewing what you've done, but you could write better commit messages. A lot of your opening comment should be in the commit messages, see making commits. |
|
Please don't push the formatting changes. |
|
Thanks for the feedback! Noted on the commit messages — I understand that they should be more Regarding formatting changes, thanks for pointing that out. |
The About dialog positions navigation arrows absolutely without reserving horizontal space for content. This caused text to flow under the arrows on smaller and medium screen sizes. Add horizontal padding to the content container to create safe spacing zones and prevent overlap across common breakpoints. Fixes sugarlabs#5290
04b5ea4 to
03e68fa
Compare
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
|
@walterbender I think we have merged the fix, so should we close the PR? |
|
Thanks for checking! Yes, the fix has already been merged via another PR, so this PR can be closed. |
Fixes: #5290
Summary
Fixes a UI bug where the navigation arrows overlap the text content in the About dialog.
Explanation
Why the overlap was happening
#helpBodyDiv) had no horizontal padding reserved for the arrows.What this fix does
#helpBodyDivto create safe spacing zones for the arrows.Padding values used:
Code Changes
css/activities.css