Fixed the trash color inconsistency in dark mode#5311
Merged
walterbender merged 2 commits intosugarlabs:masterfrom Feb 3, 2026
Merged
Fixed the trash color inconsistency in dark mode#5311walterbender merged 2 commits intosugarlabs:masterfrom
walterbender merged 2 commits intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
Author
|
@walterbender @omsuneri please review |
Member
|
Seems hard to see the blocks in the trash with this change. Maybe those colors need adjusting as well in DarkMode? |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
Author
|
I've addressed the block icon visibility issue in dark mode. 
|
Member
|
Looks much better. |
vanshika2720
pushed a commit
to vanshika2720/musicblocks
that referenced
this pull request
Feb 11, 2026
* Fixed the color inconsistency in dark mode * Improve block icon visibility in dark mode trash view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In dark mode, the Trash View UI elements were using light-mode styles.
This PR adds missing dark mode styles for the Trash View components to improve visual consistency when the application is in dark mode.
BEFORE:
AFTER:
FIXES : #5350