Fix JS editor syntax highlighting regression (#5334)#5339
Closed
severe77 wants to merge 1 commit intosugarlabs:masterfrom
Closed
Fix JS editor syntax highlighting regression (#5334)#5339severe77 wants to merge 1 commit intosugarlabs:masterfrom
severe77 wants to merge 1 commit intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Member
|
Another (earlier) PR addressed this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a regression in the JavaScript editor where syntax highlighting
fails due to a highlight.js API mismatch.
Problem
The current code assumes the presence of
hljs.highlightElement, which is notavailable in older highlight.js versions that are still used in some setups.
As a result, the editor opens without syntax highlighting, even though the
highlighter library is loaded.
While the issue mentions load order, the root cause here is an API mismatch.
The highlighter is already loaded, but the expected DOM-highlighting method
differs across highlight.js versions.
Solution
This change keeps the existing behavior for newer highlight.js versions and
adds a backward-compatible fallback to
hljs.highlightBlockwhenhighlightElementis not available. This restores syntax highlighting acrossboth old and new highlight.js APIs without changing load order or introducing
side effects.
Why this approach
Fixes #5334