Skip to content

[Chore] Add Meter palette tests (Beginner & Advanced)#5614

Open
vanshika2720 wants to merge 1 commit intosugarlabs:masterfrom
vanshika2720:feat/meter-palette-tests
Open

[Chore] Add Meter palette tests (Beginner & Advanced)#5614
vanshika2720 wants to merge 1 commit intosugarlabs:masterfrom
vanshika2720:feat/meter-palette-tests

Conversation

@vanshika2720
Copy link
Contributor

@vanshika2720 vanshika2720 commented Feb 8, 2026

This PR expands the Music Blocks test suite by adding structured tests for the Meter palette, covering both Beginner and Advanced blocks.

What’s included

Meter palette (Beginner)

New action block tests validating basic meter configuration:

  • set meter with common time (4/4)
  • set meter with triple meter (3/4)
  • set meter with compound meter (6/8)
  • Verification of beats per measure and note value per beat

These tests focus on core time-signature behavior without tempo changes or polymeter.

Meter palette (Advanced)

New action block tests covering advanced meter features:

  • pickup to validate anacrusis handling
  • tempo to verify BPM changes in meter context
  • polymeter to confirm independent meters across voices

Each test isolates a single advanced concept to keep behavior explicit and easy to debug.

Organization

  • Tests are organized into separate action blocks for Beginner and Advanced Meter palettes
  • Action blocks are attached to the start block following the existing test suite pattern
  • No pitch, ornament, or tone logic is included in this PR

Scope

This PR is limited to the Meter palette only. Other palettes (Pitch, Intervals, Tone, Ornament, Drum) will be addressed in separate PRs to keep changes reviewable.

Testing

All tests follow the structure of existing Music Blocks test suite examples and run within the current test framework.

  • Tests

Closes

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2026

✅ All Jest tests passed! This PR is ready to merge.

@vanshika2720
Copy link
Contributor Author

@walterbender

@walterbender
Copy link
Member

image

Seems really broken. How did you test this?

@vanshika2720
Copy link
Contributor Author

@walterbender yes,I tested the changes locally, but after reviewing again I found that something is not working correctly in the test suite. I’m currently fixing the issue and will push an updated commit once everything runs without errors.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@vanshika2720 vanshika2720 force-pushed the feat/meter-palette-tests branch from 62f6bdc to 54d9f97 Compare February 18, 2026 23:19
@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

6 similar comments
@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@walterbender
Copy link
Member

Sort of kind of the right idea. Your test for beats per minute works, as does your test for current meter. Not sure what the 3rd start block is for. But these tests should be in an action block, not individual start blocks. And the action block should be called from the original start block as per the others.

No idea what all the js code changes are for.

@vanshika2720
Copy link
Contributor Author

@walterbender The third start block was originally added to isolate the initialization for the time signature listener, but I’m still working on this and refining the structure. I agree it doesn’t need to live separately, so I’ll move the BPM, meter, and related checks into a single action block and have it triggered from the primary start block, consistent with the existing pattern.

I’ll update the structure accordingly once that’s in place.

@vanshika2720 vanshika2720 force-pushed the feat/meter-palette-tests branch from d76b6ba to 0a4a86d Compare March 8, 2026 16:52
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2026

✅ All Jest tests passed! This PR is ready to merge.

@github-actions github-actions bot added the tests Adds or updates test coverage label Mar 8, 2026
@vanshika2720 vanshika2720 force-pushed the feat/meter-palette-tests branch from 0a4a86d to 61fab2f Compare March 8, 2026 17:23
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2026

✅ All Jest tests passed! This PR is ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Adds or updates test coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants