[Chore] Add Meter palette tests (Beginner & Advanced)#5614
[Chore] Add Meter palette tests (Beginner & Advanced)#5614vanshika2720 wants to merge 1 commit intosugarlabs:masterfrom
Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@walterbender yes,I tested the changes locally, but after reviewing again I found that something is not working correctly in the test suite. I’m currently fixing the issue and will push an updated commit once everything runs without errors. |
|
✅ All Jest tests passed! This PR is ready to merge. |
62f6bdc to
54d9f97
Compare
|
✅ All Jest tests passed! This PR is ready to merge. |
6 similar comments
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
Sort of kind of the right idea. Your test for beats per minute works, as does your test for current meter. Not sure what the 3rd start block is for. But these tests should be in an action block, not individual start blocks. And the action block should be called from the original start block as per the others. No idea what all the js code changes are for. |
|
@walterbender The third start block was originally added to isolate the initialization for the time signature listener, but I’m still working on this and refining the structure. I agree it doesn’t need to live separately, so I’ll move the BPM, meter, and related checks into a single action block and have it triggered from the primary start block, consistent with the existing pattern. I’ll update the structure accordingly once that’s in place. |
d76b6ba to
0a4a86d
Compare
|
✅ All Jest tests passed! This PR is ready to merge. |
0a4a86d to
61fab2f
Compare
|
✅ All Jest tests passed! This PR is ready to merge. |

This PR expands the Music Blocks test suite by adding structured tests for the Meter palette, covering both Beginner and Advanced blocks.
What’s included
Meter palette (Beginner)
New action block tests validating basic meter configuration:
set meterwith common time (4/4)set meterwith triple meter (3/4)set meterwith compound meter (6/8)beats per measureandnote value per beatThese tests focus on core time-signature behavior without tempo changes or polymeter.
Meter palette (Advanced)
New action block tests covering advanced meter features:
pickupto validate anacrusis handlingtempoto verify BPM changes in meter contextpolymeterto confirm independent meters across voicesEach test isolates a single advanced concept to keep behavior explicit and easy to debug.
Organization
Scope
This PR is limited to the Meter palette only. Other palettes (Pitch, Intervals, Tone, Ornament, Drum) will be addressed in separate PRs to keep changes reviewable.
Testing
All tests follow the structure of existing Music Blocks test suite examples and run within the current test framework.
Closes