fix: guard startup doSearch initialization#5622
Closed
Dodothereal wants to merge 1 commit intosugarlabs:masterfrom
Closed
fix: guard startup doSearch initialization#5622Dodothereal wants to merge 1 commit intosugarlabs:masterfrom
Dodothereal wants to merge 1 commit intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
@Dodothereal A PR(#5314 ) already exits on this issue . |
Author
|
Closing to avoid duplicate/overlapping work. I will only submit PRs for clearly unclaimed issues (no active PR and no contributor already working on it). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
doSearch()call inindex.htmlwith a bounded readiness checkwindow.activity.doSearchandsearchWidgetare availableTesting
npm run linthttp://127.0.0.1:3000with Playwright CLI and confirmed nodoSearch is not definedstartup errorFixes #5313