Skip to content

fix: guard startup doSearch initialization#5622

Closed
Dodothereal wants to merge 1 commit intosugarlabs:masterfrom
Dodothereal:codex/fix-5313-startup-dosearch
Closed

fix: guard startup doSearch initialization#5622
Dodothereal wants to merge 1 commit intosugarlabs:masterfrom
Dodothereal:codex/fix-5313-startup-dosearch

Conversation

@Dodothereal
Copy link

Summary

  • replace the unconditional doSearch() call in index.html with a bounded readiness check
  • initialize search only after window.activity.doSearch and searchWidget are available
  • avoid startup race conditions from script load order

Testing

  • npm run lint
  • loaded http://127.0.0.1:3000 with Playwright CLI and confirmed no doSearch is not defined startup error

Fixes #5313

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2026

✅ All Jest tests passed! This PR is ready to merge.

@vanshika2720
Copy link
Contributor

vanshika2720 commented Feb 8, 2026

@Dodothereal A PR(#5314 ) already exits on this issue .

@Dodothereal
Copy link
Author

Closing to avoid duplicate/overlapping work. I will only submit PRs for clearly unclaimed issues (no active PR and no contributor already working on it).

@Dodothereal Dodothereal closed this Feb 8, 2026
@Dodothereal Dodothereal deleted the codex/fix-5313-startup-dosearch branch February 8, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] ReferenceError during startup when doSearch is not defined

2 participants