Fix staccato/slur listener name collision on nested blocks

[Ady0333]

Summary

Fixes a listener name collision between Staccato and Slur blocks that caused articulation state to leak when nested.

Both blocks registered their cleanup listeners under the same name ("_staccato_" + turtle). When nested, the inner block overwrote the outer block’s listener, preventing the outer cleanup from running. This left a phantom entry in tur.singer.staccato, causing incorrect articulation for subsequent notes.

---

What changed

Updated the listener name in both setStaccato() and setSlur() to include the block id:

Before:

const listenerName = "_staccato_" + turtle;

After:

const listenerName = "_staccato_" + turtle + "_" + blk;
This ensures each block instance registers a unique listener.

---

Impact

• Fixes Slur inside Staccato and Staccato inside Slur nesting
• Prevents phantom articulation entries
• Restores correct clamp isolation behavior
• No changes to scheduling or audio logic

---

Verification

• Tested nested Slur/Staccato combinations
• Confirmed articulation resets correctly after block exit
• No regressions in standalone articulation behavior

[github-actions]

✅ All Jest tests passed! This PR is ready to merge.

[Ady0333]

@walterbender and @vanshika2720, the pr is ready review it once.

[kartikktripathi]

Confirmed the listener collision fix resolves nested Slur/Staccato articulation leakage and preserves existing behaviour.
Approving. Thanks for the contribution!

@walterbender, this PR is ready to be merged.

[vanshika2720]

@Ady0333 Scoping the listener name to turtle + "_" + blk correctly isolates nested blocks and fixes the collision issue. The test updates properly reflect the dynamic listener key and validate cleanup behavior.

One small note: if blk is ever undefined, the listener name will include _undefined — not blocking, but worth confirming that’s intentional.

Overall, this is a clean and well-contained fix

[kartikktripathi]

@Ady0333 Scoping the listener name to turtle + "_" + blk correctly isolates nested blocks and fixes the collision issue. The test updates properly reflect the dynamic listener key and validate cleanup behavior.

One small note: if blk is ever undefined, the listener name will include _undefined — not blocking, but worth confirming that’s intentional.

Overall, this is a clean and well-contained fix

I tested runtime calls without a block id (blk undefined) in the console, articulation state stacks and cleans correctly, so there’s no observable leak in that path. Looks safe to me.

[vanshika2720]

@kartikktripathi Thanks for verifying the blk undefined path
Good to know runtime calls without a block id still clean up articulation state correctly and don’t leak.

With that confirmed, this looks safe to merge from my side also.