Fix: remove black empty space in fullscreen mode (#5774)#5775
Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
|
Hello @walterbender @omsuneri, I’d appreciate it if you could review this PR at your convenience. Thank you! |
There was a problem hiding this comment.
@anshukaushik4700 The --vh viewport fix is correct and should resolve the fullscreen black space issue across browsers.
One small question: since resizing the canvas resets its drawing buffer, are we certain this won't introduce flicker or unintended redraw behavior?
|
@vanshika2720 Thanks for the review and for pointing that out. In Music Blocks, the canvas redraw is already handled as part of the normal render loop (e.g. during playback, interactions, and layout changes). The height update happens only on fullscreen toggle or resize events, not continuously, so it shouldn’t introduce noticeable flicker. I also tested repeated fullscreen toggling and window resizing, and didn’t observe any unintended redraw artifacts or visual glitches. Given the existing redraw behavior, this change should be safe across browsers. |
|
Hi @walterbender , |
Description
This pull request fixes the black empty space appearing at the bottom of the Music Blocks main editor in fullscreen mode. The issue occurred when switching to fullscreen or resizing the browser, causing the editor container to not properly fill the viewport.
What was changed:
How to Test:
Screenshots / Videos:

Demonstration of the fix in action: https://www.loom.com/share/8555bfd69885488b9abcab083e57149c
References the issue:
Closes #5774