Open
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
Contributor
|
@manvirsingh01 please pull the latest master, rebase it into your branch, and push again. |
- Add local toTitleCase() function in planet/js/GlobalTag.js since it runs inside the Planet iframe without access to the global from js/utils/utils.js. - Remove orphaned doSearch() call from index.html that ran at $(document).ready() time before the Activity object was created. Fixes: toTitleCase is not defined, doSearch is not defined
manvirsingh01
force-pushed
the
fix/stop-button-visibility
branch
from
6af6cd5 to
94bef72
Compare
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Author
|
@vanshika2720 Thank you for your help earlier. I’ve pulled the latest master, rebased, resolved the issues, and pushed the updates. Could you please review the PR now? |
Contributor
There was a problem hiding this comment.
@manvirsingh01 The Stop button fix works correctly and testing looks good.
However, the Node version update and GlobalTag changes are unrelated to this fix.
It would be cleaner to move those into separate PRs to keep changes scoped.
and also resolve merge conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Only show Stop during active playback #5779
Description:
This PR fixes the confusing UI state where the Stop button appears on page load even though nothing is playing. Stop is now hidden by default, shown only while playback is active, and hidden again when playback ends or is stopped. This aligns the toolbar with actual playback state and prevents users from seeing an inert Stop control.
Changes:
onRunTurtle/onStopTurtle).Testing:
npm test@walterbender can you review