Improve macros.js test coverage and fixed module export in macros.js#5784
Merged
omsuneri merged 2 commits intosugarlabs:masterfrom Feb 19, 2026
Merged
Improve macros.js test coverage and fixed module export in macros.js#5784omsuneri merged 2 commits intosugarlabs:masterfrom
omsuneri merged 2 commits intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
@stutijain2006 please pull the latest master, rebase it into your branch, and push again. |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the test case coverages of macros.js and fixes an issue with how functions were being imported.
Test Cases Added-
Module Export Issue-
Previously macros.js exported functions like this:
the second line overwrites the first export, making only getMacroExpansion accessible.
Now, both functions are exported properly:
module.exports = { blockIsMacro, getMacroExpansion };and the import in tests was updated to
const { blockIsMacro, getMacroExpansion } = require("../macros");After these additions-
This ensures macros.js is now fully tested and more robust against edge cases.