Improve trash-hover chunk shrink behavior and drag/drop stability#5788
Improve trash-hover chunk shrink behavior and drag/drop stability#5788Siddharth-732 wants to merge 3 commits intosugarlabs:masterfrom
Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@Siddharth-732 CI check is failing. |
|
I'll fix it shortly. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@vanshika2720 Hi, could you please help me with the CI failure? I haven’t made any dependency-related changes in this PR (only changes in block.js). Verified the PR is opened from my ui branch into sugarlabs:master. Synced my branch with the latest upstream/master (it was already up to date). Confirmed that package.json was not modified by my changes. Tried reinstalling dependencies locally using npm install. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@Siddharth-732 try changeing "electron-builder" version to "26.7.0" both in package.json and package-lock.json |
|
@Siddharth-732 I think you got your answer...and if you have any other confusion/or need help please let me know. |
|
@Siddharth-732 bro take pull from latest commit and re run ci, it should work now :) |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
Finally ! |
|
@walterbender @omsuneri please review this, let me know if any changes are required. |
|
@Siddharth-732 hy siddhart this can be good addition |
|
Meet will be on next Sunday right ? |
yes |
Fixes #5787
Summary
This PR improves the trash-delete drag UX for block stacks by making delete interactions clearer, safer, and more stable during drag operations.
What’s Changed
File Changed
block.jsHow the Issue Was Solved
_setDragGroupTrashHoverScale(...)to manage a reversible hover-shrink state for the active drag group.blocks.dragGroup(the currently dragged stack), ensuring unrelated blocks are unaffected._dragPointerDown) so transient mouseout events during drag do not trigger drop or delete logic.pressup) while over the trash area.Video
Music.Blocks.and.4.more.pages.-.Personal.-.Microsoft_.Edge.2026-02-18.19-14-17.mp4
Result