Fix dark mode search text contrast#5791
Closed
Ady0333 wants to merge 1 commit intosugarlabs:masterfrom
Closed
Conversation
Signed-off-by: Ady0333 <adityashinde1525@gmail.com>
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
i believe there's an open PR on this exact issue, (#5681) Please consider closing your PR to keep the reviewing easy. |
Contributor
Author
Well okay!! I'll close my PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a low-contrast issue in the search dropdown when using dark mode. The block labels inside the autocomplete list were rendered in dark gray text on a dark background, making them difficult to read.
What was happening
The search dropdown renders block labels inside tags. The jQuery UI base theme applies:
.ui-widget-content a { color: #333333; }
This overrides the inherited white text color in dark mode, resulting in dark gray text on a dark background.
What changed
Added a dark-mode specific override in css/themes.css:
body.dark .ui-autocomplete a {
color: #fff !important;
}
This increases selector specificity and restores proper contrast in dark mode without affecting light mode.
Scope
Verification
Before
After