Skip to content

Batch canvas rendering using stageDirty flag to reduce redundant stage.update() calls #5807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
walterbender merged 3 commits into from
Mar 15, 2026
Merged

Batch canvas rendering using stageDirty flag to reduce redundant stage.update() calls #5807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1438d0
Batch canvas rendering using stageDirty flag
stutijain2006 Feb 19, 2026
f558d06
Formatted document
stutijain2006 Feb 19, 2026
3ef4f6c
Run prettier on modified files
stutijain2006 Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions js/activity.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2308,7 +2308,7 @@ class Activity {
}

await this.setSmallerLargerStatus();
await this.stage.update();
this.stageDirty = true;
};

/**
Expand Down Expand Up @@ -2348,7 +2348,7 @@ class Activity {
}

await this.setSmallerLargerStatus();
await this.stage.update();
this.stageDirty = true;
};

/*
Expand Down Expand Up @@ -2938,7 +2938,7 @@ class Activity {
isIdle = false;
createjs.Ticker.framerate = ACTIVE_FPS;
// Force immediate redraw for responsiveness
if (this.stage) this.stage.update();
this.stageDirty = true;
}
};

Expand Down Expand Up @@ -3606,7 +3606,7 @@ class Activity {
disableHorizScrollIcon.style.display == "block"
) {
this.blocksContainer.x += this.canvas.width / 10;
this.stage.update();
this.stageDirty = true;
}
// fall through
case 220:
Expand All @@ -3616,7 +3616,7 @@ class Activity {
disableHorizScrollIcon.style.display == "block"
) {
this.blocksContainer.x -= this.canvas.width / 10;
this.stage.update();
this.stageDirty = true;
}
}
} else if (event.ctrlKey) {
Expand Down Expand Up @@ -3675,17 +3675,17 @@ class Activity {
this.textMsg("END " + _("Jumping to the bottom of the page."));
this.blocksContainer.y =
-this.blocks.bottomMostBlock() + this.canvas.height / 2;
this.stage.update();
this.stageDirty = true;
break;
case PAGE_UP:
this.textMsg("PAGE_UP " + _("Scrolling up."));
this.blocksContainer.y += this.canvas.height / 2;
this.stage.update();
this.stageDirty = true;
break;
case PAGE_DOWN:
this.textMsg("PAGE_DOWN " + _("Scrolling down."));
this.blocksContainer.y -= this.canvas.height / 2;
this.stage.update();
this.stageDirty = true;
break;
case DEL:
this.textMsg("DEL " + _("Extracting block"));
Expand All @@ -3709,7 +3709,7 @@ class Activity {
} else {
this.blocksContainer.y += 20;
}
this.stage.update();
this.stageDirty = true;
}
break;
case KEYCODE_DOWN:
Expand All @@ -3733,7 +3733,7 @@ class Activity {
} else {
this.blocksContainer.y -= 20;
}
this.stage.update();
this.stageDirty = true;
}
break;
case KEYCODE_LEFT:
Expand All @@ -3750,7 +3750,7 @@ class Activity {
} else if (this.scrollBlockContainer) {
this.blocksContainer.x += 20;
}
this.stage.update();
this.stageDirty = true;
}
break;
case KEYCODE_RIGHT:
Expand All @@ -3767,7 +3767,7 @@ class Activity {
} else if (this.scrollBlockContainer) {
this.blocksContainer.x -= 20;
}
this.stage.update();
this.stageDirty = true;
}
break;
case HOME:
Expand All @@ -3785,7 +3785,7 @@ class Activity {
// Bring all the blocks "home".
this._findBlocks();
}
this.stage.update();
this.stageDirty = true;
break;
case TAB:
break;
Expand Down
2 changes: 1 addition & 1 deletion js/turtle-singer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2537,7 +2537,7 @@ class Singer {
callback();
}

activity.stage.update();
activity.stageDirty = true;
}
}

Expand Down
Loading