feat(accessibility): enable keyboard navigation for toolbar controls#5819
Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@vanshika2720 Could you please confirm if this scope looks correct for the issue |
|
@Commanderk3 Can you review this PR and tell me if this needs further changes or it is good to go. |
|
@DhyaniKavya could you post a video here? On my testing I did not find any highlights on buttons when pressed TAB. |
|
✅ All Jest tests passed! This PR is ready to merge. |
Keyboard.Accessibility.mp4@Commanderk3 Thanks for checking this earlier. I believe the focusability was present, but the focus indicator was not clearly visible against the toolbar background, which made it appear as if focus was missing. |
|
Yup, It is working fine now. Nice work. |
|
Thankyou for Reviewing this and guiding me properly . It feels good to work with such guidance. 🙌 |
|
@walterbender @omsuneri please review the changes. If anything needs to change , i am open to address it. Thankyou |
issue : #5809
Problem:
Toolbar icons function as buttons but are not keyboard focusable,
preventing keyboard navigation and violating accessibility guidelines.
Solution:
Adds role="button" and tabindex="0" to toolbar anchor elements
to enable keyboard focus and interaction.
Changes:
Testing:
This PR focuses only on toolbar accessibility improvements.