Minimal fix: remove leftover debug logging from plugin evaluation#5821
Merged
omsuneri merged 1 commit intosugarlabs:masterfrom Feb 19, 2026
Merged
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
Author
|
@omsuneri I have created a new branch for minimal changes. Previous branch has unrelated and large changes that are leading to no point. Here, i have done minimal changes explaining what is the problem and what could be the solution. Please review these changes .If there is any change required , i am open to address it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: #5811
Problem:-
A debug logging statement remains in js/logo.js that prints plugin execution details to the browser console during normal operation.
-Logs "running eval on ..." whenever plugin blocks are evaluated
-Intended only for debugging purposes
-Allowed via an ESLint disable comment
-Creates unnecessary console noise in production
-Exposes internal execution details
-Although functionality is unaffected, this reduces developer experience and code professionalism.
Solution:-
-This PR removes the leftover debug logging while keeping plugin execution behavior unchanged.
-removes the debug console.log statement
-removes the associated ESLint disable comment
-preserves all existing functionality
-keeps console output clean during normal execution
-This refinement ensures the change is minimal and easy to review.
Changes Made:-
-File modified:
->js/logo.js
->removed debug console logging from plugin evaluation
->removed unnecessary eslint disable comment
->added brief comment noting intentional removal (if applicable)
Testing Performed:-
-Manual Verification
-Loaded projects using plugin blocks (e.g., hue block)
-Executed projects normally
-Verified plugin functionality remains unchanged
-Confirmed console no longer displays debug messages
-No console errors observed
-Automated Testing
Jest: ✅ all tests passed
ESLint: ✅ no new lint errors introduced
Impact:-
-Removes console clutter during normal execution
-Improves developer debugging experience
-Prevents exposure of internal execution details
-Enhances production code hygiene
-No functional changes
Notes:-
This PR is a refined version with minimal changes affecting only js/logo.js to ensure easy review and maintain code clarity.
Happy to adjust if maintainers prefer restricting such logs to a development-only debug mode.