Fix: prevent resize listener accumulation in makeBackground#5824
Merged
walterbender merged 1 commit intosugarlabs:masterfrom Mar 14, 2026
Merged
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
kartikktripathi
approved these changes
Feb 20, 2026
Contributor
kartikktripathi
left a comment
There was a problem hiding this comment.
This looks good to me. The resize listener accumulation issue is addressed properly by storing the handler reference and ensuring any existing listener is removed before registering a new one.
The fix is clean, scoped, and improves lifecycle stability without altering existing behaviour.
Contributor
Author
|
@walterbender could you please take a look at this pr when you have some time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a resize listener accumulation issue in
js/turtles.jsinside the
Turtles.TurtlesViewclass.Problem
In the
makeBackground()method, a newwindow.resizeevent listenerwas being registered each time the method was called.
Since the resize handler reference was not preserved across calls,
previously registered listeners were not removed before adding new ones,
leading to multiple active resize listeners.
Because
makeBackground()may run multiple times during normalcanvas updates, this could result in multiple resize listeners
being attached.
Solution
Defined a named
resizeHandlerfunction insidemakeBackground().Stored the handler reference on the instance (
this._resizeHandler).Before registering a new listener, the existing one (if present)
is removed using: