Update musicutils.test.js#5831
Open
Aayush-kumar-ctrl wants to merge 1 commit intosugarlabs:masterfrom
Open
Conversation
Update musicutils.test.js chore: implement _calculate_pitch_number and getPitchInfo helpers Added MIDI-based pitch calculation and structured pitch parsing to musicutils.js. Handles enharmonic equivalents and invalid input.
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
Contributor
There was a problem hiding this comment.
@Aayush-kumar-ctrl I noticed that this PR adds implementation code (_calculate_pitch_number, getPitchInfo, exports, etc.) inside what appears to be a test file.
Since the PR title mentions updating musicutils.test.js, could you clarify whether this logic is meant to go into musicutils.js instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update musicutils.test.js
chore: implement _calculate_pitch_number and getPitchInfo helpers
Added MIDI-based pitch calculation and structured pitch parsing
to musicutils.js. Handles enharmonic equivalents and invalid input.