Skip to content

fix: replace global focus outline removal with :focus-visible for key… #5839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manvirsingh01 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: replace global focus outline removal with :focus-visible for key… #5839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion css/activities.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,17 @@

@import url("play-only-mode.css");

*:focus {
/* Hide focus ring for mouse/touch interactions */
*:focus:not(:focus-visible) {
outline: none;
}

/* Show visible focus ring for keyboard navigation (WCAG 2.4.7) */
*:focus-visible {
outline: 2px solid #0066FF;
outline-offset: 2px;
}

body:not(.dark) #helpfulSearch,
body:not(.dark) .ui-autocomplete {
background-color: #fff !important;
Expand Down
2 changes: 1 addition & 1 deletion css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ input[type="range"] {
width: 250px;
}

input[type="range"]:focus {
input[type="range"]:focus:not(:focus-visible) {
outline: none;
}

Expand Down
2 changes: 1 addition & 1 deletion planet/css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,5 +507,5 @@ a {
border-radius: 5px;
cursor: pointer;
font-size: 16px;
outline: none;
/* outline preserved for keyboard focus via global :focus-visible rule */
}
Loading