synth recording flow with MBDialog#5846
Open
zealot-zew wants to merge 1 commit intosugarlabs:masterfrom
Open
Conversation
This PR replaces the native browser prompt in synthutils.js with the newly created MBDialog component. This ensures that the "Save music as WAV" action now uses a themed UI that is consistent with the rest of the application.
15 tasks
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
github-actions
bot
added
feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on PR #5844 (MERGED) for MBDialog component
This PR replaces the native browser prompt in synthutils.js with the newly created MBDialog component. This ensures that the "Save music as WAV" action now uses a themed UI that is consistent with the rest of the application.
Clarification Needed: The recording saves only when the stop button is pressed after starting the music recording, is this a bug or a feature.
Images:
