Fix canplay listener and interval accumulation in doUseCamera()#5847
Closed
kartikktripathi wants to merge 5 commits intosugarlabs:masterfrom
Closed
Fix canplay listener and interval accumulation in doUseCamera()#5847kartikktripathi wants to merge 5 commits intosugarlabs:masterfrom
kartikktripathi wants to merge 5 commits intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
Author
|
Hey @walterbender, this PR is ready for review. Please take a look. |
shashank03-dev
approved these changes
Feb 22, 2026
shashank03-dev
left a comment
There was a problem hiding this comment.
dude this code looks solid, the tests are green, and the PR description is very clear. Approving this from my end
Contributor
Author
|
@shashank03-dev, thanks for the review! |
Member
|
please address the merge conflict |
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
Contributor
Author
|
Hi @walterbender, I have resolved the conflicts which had appeared. Please take a look when you get time. Thanks! |
Contributor
Author
|
This issue has been solved in #5837. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes event listener and interval accumulation in
doUseCamera()(js/utils/utils.js).Previously, each invocation of
doUseCamera()attached a new"canplay"listener usingaddEventListenerand could create multiple activesetIntervalloops without reliably clearing the previous one. This could lead to:Changes
Replaced:
with:
This ensures only a single
canplayhandler is active at any time.&
Added defensive cleanup before starting a new interval:
This prevents interval stacking when the camera is re-triggered.
Testing
Start → Show → Camerablock in UI.npm testtest suites.Notes
The fix prevents resource accumulation while preserving existing camera behaviour.
PR Category
Thanks!