Fix/service worker offline fallback#5875
Open
DhyaniKavya wants to merge 3 commits intosugarlabs:masterfrom
Open
Fix/service worker offline fallback#5875DhyaniKavya wants to merge 3 commits intosugarlabs:masterfrom
DhyaniKavya wants to merge 3 commits intosugarlabs:masterfrom
Conversation
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
1 similar comment
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
Contributor
|
pre-existing jest failures?? |
Contributor
|
I think they are mostly reference and type errors . |
Contributor
Author
|
@omsuneri The failing Jest tests appear to be pre-existing and reproducible on the current master branch. |
5baead0 to
e61ead5
Compare
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
Author
|
@omsuneri @walterbender Rebased the branch successfully and all tests are passing now . Please review the changes, if anything needs change, i am open to address it. Thankyou. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue : #5874
Problem:-
The service worker references an offlineFallbackPage variable when handling failed network requests:
=> const fallbackResponse = await caches.match(offlineFallbackPage);
However, offlineFallbackPage is only declared in a lint hint comment:
=> /* global offlineFallbackPage */
and is never defined at runtime. This can lead to a ReferenceError when the service worker attempts to serve a fallback response during offline conditions.
-Offline navigation may fail silently
-Users may see a blank page when offline
-PWA reliability is degraded
Solution:-
-This PR defines the fallback page variable to ensure the service worker can safely return a cached response when offline.
-defines offlineFallbackPage in sw.js
-uses an existing cached resource (./index.html) as fallback
-preserves existing fetch handler logic
-prevents runtime errors during offline fallback
Changes Made:-
-File modified:
->sw.js
ESLint: ✅ no lint errors⚠️ pre-existing failures on master (unrelated to this change)
Tests:
Impact:-
-Prevents runtime errors in offline mode
-Improves Progressive Web App reliability
-Ensures graceful fallback when offline
-No functional or behavioral regressions
Notes:-
This change is intentionally minimal and non-breaking. It defines the expected fallback variable while preserving existing service worker logic and caching behavior.
Happy to refine further if maintainers prefer a dedicated offline page in the future.