Skip to content

Protect timing execution semantics in RhythmActions with regression tests#5887

Open
mahesh-09-12 wants to merge 1 commit intosugarlabs:masterfrom
mahesh-09-12:test/rhythmactions-regression-guards
Open

Protect timing execution semantics in RhythmActions with regression tests#5887
mahesh-09-12 wants to merge 1 commit intosugarlabs:masterfrom
mahesh-09-12:test/rhythmactions-regression-guards

Conversation

@mahesh-09-12
Copy link
Contributor

@mahesh-09-12 mahesh-09-12 commented Feb 23, 2026

Description

This PR adds regression tests protecting execution semantics in RhythmActions, including:

  • beatFactor lifecycle restoration after dot/multiply
  • duration resolution priority in getNoteValue
  • osctime vs note behavior differences
  • nested note voice activation

No production code changes.
All existing tests pass.
Focus is on protecting timing invariants from future refactors.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@mahesh-09-12
Copy link
Contributor Author

Hi @walterbender @omsuneri, added regression guards around timing invariants in RhythmActions to prevent silent execution drift during refactors.
Would appreciate feedback when you get time.

@mahesh-09-12 mahesh-09-12 force-pushed the test/rhythmactions-regression-guards branch from 500fa45 to 3e83084 Compare February 23, 2026 09:22
@github-actions
Copy link
Contributor

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Failed Tests:

palette.test.js
logo.test.js
logoconstants.test.js

@omsuneri
Copy link
Member

@mahesh-09-12 please rebase your branch with upstream master

@mahesh-09-12 mahesh-09-12 force-pushed the test/rhythmactions-regression-guards branch from 3e83084 to 79b7972 Compare February 26, 2026 04:18
@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@mahesh-09-12
Copy link
Contributor Author

@omsuneri rebased with upstream master, all checks are passing.

@mahesh-09-12
Copy link
Contributor Author

Hi @omsuneri , just a gentle follow-up. The branch has been rebased with upstream master and all checks are passing. Please let me know if any further changes are needed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants