Protect timing execution semantics in RhythmActions with regression tests#5887
Open
mahesh-09-12 wants to merge 1 commit intosugarlabs:masterfrom
Open
Protect timing execution semantics in RhythmActions with regression tests#5887mahesh-09-12 wants to merge 1 commit intosugarlabs:masterfrom
mahesh-09-12 wants to merge 1 commit intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
Author
|
Hi @walterbender @omsuneri, added regression guards around timing invariants in RhythmActions to prevent silent execution drift during refactors. |
500fa45 to
3e83084
Compare
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
Member
|
@mahesh-09-12 please rebase your branch with upstream master |
3e83084 to
79b7972
Compare
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
Author
|
@omsuneri rebased with upstream master, all checks are passing. |
Contributor
Author
|
Hi @omsuneri , just a gentle follow-up. The branch has been rebased with upstream master and all checks are passing. Please let me know if any further changes are needed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds regression tests protecting execution semantics in RhythmActions, including:
No production code changes.
All existing tests pass.
Focus is on protecting timing invariants from future refactors.