fix(a11y): enable keyboard access for popup close buttons #5878#5893
Open
Ananya-Kaushal137 wants to merge 5 commits intosugarlabs:masterfrom
Open
fix(a11y): enable keyboard access for popup close buttons #5878#5893Ananya-Kaushal137 wants to merge 5 commits intosugarlabs:masterfrom
Ananya-Kaushal137 wants to merge 5 commits intosugarlabs:masterfrom
Conversation
enable keyboard access for popup close button (sugarlabs#5878)
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
Contributor
|
Same as #5878 . Issue already raised. Please raise a new issue |
zealot-zew
reviewed
Mar 1, 2026
Contributor
zealot-zew
left a comment
zealot-zew
left a comment
There was a problem hiding this comment.
Not only works, but also made the Styling inconsistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #5878