Add unit tests for temperament.js to improve coverage#5894
Merged
omsuneri merged 2 commits intosugarlabs:masterfrom Feb 25, 2026
Merged
Add unit tests for temperament.js to improve coverage#5894omsuneri merged 2 commits intosugarlabs:masterfrom
omsuneri merged 2 commits intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
hey @stutijain2006, nice coverage addition here, good to see multiple branches of playNote, playAll, and edit modes being exercised. The constructor and save paths are also covered, which helps protect core flows. One small suggestion is some tests override internal methods like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive unit tests for the temperament.js file to improve its test coverage and reliability.
What was added:
Added test cases for core methods including:
Covered multiple execution branches such as:
Added appropriate mocking for:
Impact-