Improve test coverage for resolveObject and delayExecution#5895
Merged
omsuneri merged 2 commits intosugarlabs:masterfrom Feb 25, 2026
Merged
Improve test coverage for resolveObject and delayExecution#5895omsuneri merged 2 commits intosugarlabs:masterfrom
omsuneri merged 2 commits intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
mahesh-09-12
left a comment
There was a problem hiding this comment.
@Thesmoothengineer good coverage of null-path and error branches in resolveObject. One concern - temporarily overriding String.prototype.split introduces global side effects, even if restored. It might be safer to mock the resolution logic more locally (like spy on the utility or wrap the call) to avoid prototype mutation, otherwise this meaningfully improves defensive coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What needs testing
Improved test coverage for utility functions in
js/utils/utils.js:Current coverage
Coverage for
utils.jshad low branch and edge-case coverage, especially for:Proposed approach
Checklist