fix: replace for-in with indexed for loop in unhighlightSelectedBlocks#5903
Open
AdityaM-IITH wants to merge 1 commit intosugarlabs:masterfrom
Open
fix: replace for-in with indexed for loop in unhighlightSelectedBlocks#5903AdityaM-IITH wants to merge 1 commit intosugarlabs:masterfrom
AdityaM-IITH wants to merge 1 commit intosugarlabs:masterfrom
Conversation
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
AdityaM-IITH
force-pushed
the
fix-forin-loop-unhighlight-selected-blocks
branch
from
0913877 to
9176357
Compare
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
Author
|
Rebased on latest master. All 117 test suites passing locally. |
7se7en72025
approved these changes
Feb 26, 2026
Contributor
7se7en72025
left a comment
7se7en72025
left a comment
There was a problem hiding this comment.
LGTM. @walterbender
Verified that the fix properly replaces the for...in anti-pattern with a standard indexed loop, which preserves numeric indices and aligns with #5888.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
unhighlightSelectedBlocksmethod inactivity.jsiterates overthis.blocks.blockListusing afor...inloop.for...inon arrays yields string keys ("0", "1", "2") instead ofnumeric indices, which can cause silent failures when the index is
passed to functions expecting a number.
Changes:
for...inwith a standard indexedforloopConsistent with the fix in #5888 which addressed the same pattern in
_saveHelpBlocks.