Improved accessibility of Help widget navigation arrows (ARIA + keyboard support)#5923
Open
codeGurhans wants to merge 5 commits intosugarlabs:masterfrom
Open
Improved accessibility of Help widget navigation arrows (ARIA + keyboard support)#5923codeGurhans wants to merge 5 commits intosugarlabs:masterfrom
codeGurhans wants to merge 5 commits intosugarlabs:masterfrom
Conversation
… widget navigation arrows
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Author
|
Hi. This is just a follow up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this PR adds accessibility improvements to the Help widget navigation arrows by introducing ARIA attributes and keyboard support.
Changes Made
role="button"to the navigation arrow elementstabindex="0"to enable keyboard focusaria-labelattributes for screen reader supportImpact
These changes improve accessibility for:
Testing
Files Modified
js/widgets/help.jsThere are no visual or functional changes to the existing behavior.