fix: use dynamic backend URL in reflection.js instead of hardcoded IP#5935
Closed
amukta14 wants to merge 2 commits intosugarlabs:masterfrom
Closed
fix: use dynamic backend URL in reflection.js instead of hardcoded IP#5935amukta14 wants to merge 2 commits intosugarlabs:masterfrom
amukta14 wants to merge 2 commits intosugarlabs:masterfrom
Conversation
The crescendo end listener pops crescendoDelta and crescendoInitialVolume but never pops inCrescendo, causing it to grow unboundedly and trigger spurious volume resets on subsequent notes. Signed-off-by: Ady0333 <adityashinde1525@gmail.com>
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
Author
|
Hi, I have an open PR that fixes #5918 (reflection.js hardcoded IP): @walterbender @kartikktripathi It switches reflection.js to use a dynamic backend URL like aidebugger.js, so the Reflection widget works in local dev and production. Would appreciate a review when you have time. |
Contributor
|
Hey @amukta14, I do not see any changes in this PR, it seems like the changes you made already exist, please check and let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5918
Replaces the hardcoded backend URL ('http://3.105.177.138:8000') in reflection.js with dynamic resolution based on window.location, using the same approach as aidebugger.js.
The Reflection widget now works correctly in local development, production, and other deployments. Updated the reflection widget test to match the new behavior.