Removed incorrect node dependency causing Cl smoke test failure#5937
Open
stutijain2006 wants to merge 1 commit intosugarlabs:masterfrom
Open
Removed incorrect node dependency causing Cl smoke test failure#5937stutijain2006 wants to merge 1 commit intosugarlabs:masterfrom
stutijain2006 wants to merge 1 commit intosugarlabs:masterfrom
Conversation
Contributor
Author
|
@walterbender Node has been removed from the package.json as guided by you in the PR #5905. |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to remove the node dependency which was listed as npm package dependency and since it is a runtime environment and is already provided by the system, so having node as dependency caused the npm to install that package leading to 403 error and smoke test failure in the Cl.