fix(reflection): use dynamic backend URL instead of hardcoded IP#5954
Open
Rohit-rk07 wants to merge 2 commits intosugarlabs:masterfrom
Open
fix(reflection): use dynamic backend URL instead of hardcoded IP#5954Rohit-rk07 wants to merge 2 commits intosugarlabs:masterfrom
Rohit-rk07 wants to merge 2 commits intosugarlabs:masterfrom
Conversation
Replace hardcoded reflection backend host with hostname-aware resolution aligned with AI debugger behavior. Add unit tests for local, production, and generic host URL resolution. Fixes sugarlabs#5918.
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
@Rohit-rk07 i had already opened a pr and this issue was also opened by me. can you close your pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5918
Summary
This PR removes the hardcoded backend IP in the Reflection widget and replaces it with dynamic backend URL resolution based on
window.location, aligned with the existing AI Debugger behavior.Changes
js/widgets/reflection.js.localhost/127.0.0.1->http://localhost:8000musicblocks.sugarlabs.org->${protocol}//api.musicblocks.sugarlabs.org${protocol}//${hostname}:8000js/widgets/__tests__/reflection.test.jsto validate dynamic URL behavior.Validation
npm test -- js/widgets/__tests__/reflection.test.js --runInBand