Fix module export for oscilloscope.js to enable proper Jest coverage#5956
Open
stutijain2006 wants to merge 1 commit intosugarlabs:masterfrom
Open
Fix module export for oscilloscope.js to enable proper Jest coverage#5956stutijain2006 wants to merge 1 commit intosugarlabs:masterfrom
stutijain2006 wants to merge 1 commit intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates oscilloscope.js to properly export the Oscilloscope class using module.exports.
Previously, the test file was loading the source dynamically using fs.readFileSync and new Function(), which prevented Jest from instrumenting the file for coverage. As a result, oscilloscope.js was showing 0% coverage, even though comprehensive tests already existed.
Changes Made-
module.exports = Oscilloscope;-Updated the test file to import the module using:
const Oscilloscope = require("../oscilloscope.js");-Removed dynamic evaluation via new Function() and fs.readFileSync() from tests.
Impact-
Jest can now correctly instrument oscilloscope.js.
Coverage for oscilloscope.js went from 0% to 76%.
Existing test suite is now reflected in coverage metrics.