fix: wrap hardcoded alert() strings with _() for i18n localization#6005
fix: wrap hardcoded alert() strings with _() for i18n localization#6005vanshika2720 wants to merge 2 commits intosugarlabs:masterfrom
Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@vanshika2720 tried it locally it seems okay to me ! |
|
Looks good but there seem to be unrelated changes in sampler.js. Please remove those changes. |
f3caad7 to
f07606c
Compare
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
f07606c to
24fbd97
Compare
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
24fbd97 to
f61bc6b
Compare
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
939a4a1 to
9a9f85e
Compare
|
✅ All Jest tests passed! This PR is ready to merge. |
1 similar comment
|
✅ All Jest tests passed! This PR is ready to merge. |
9a9f85e to
8f71279
Compare
|
✅ All Jest tests passed! This PR is ready to merge. |
8f71279 to
11e898c
Compare
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
|
@vanshika2720 there is still lint faling in sampler.js |
|
@Ashutoshx7 YES i am working on it. |
11e898c to
c6a06de
Compare
|
✅ All Jest tests passed! This PR is ready to merge. |
@walterbender Done |
fix: localize hardcoded alert() strings for full i18n coverage
What
Wraps all hardcoded English
alert()strings with_()so they participate in Music Blocks’ i18n system and are translatable for non-English users.This completes a targeted audit of user-facing alert dialogs across the JavaScript codebase.
Files Changed (5)
js/blocks/ProgramBlocks.jsjs/activity.jsjs/utils/synthutils.jsjs/widgets/sampler.jsjs/loader.jsNotable Implementation Detail
loader.jsBootstrap Guardloader.jsexecutes during early RequireJS bootstrap, before_()is guaranteed to exist.Each alert site uses an inline safety guard:
This is intentional because:
There are no functional behavior changes — only localization support added.
Intentionally Not Changed
Scope
This keeps the PR small, reviewable, low-risk, and focused strictly on improving i18n coverage.