fix: guard GraphicsBlocks arg parent lookups#6180
Open
Rohit-rk07 wants to merge 1 commit intosugarlabs:masterfrom
Open
fix: guard GraphicsBlocks arg parent lookups#6180Rohit-rk07 wants to merge 1 commit intosugarlabs:masterfrom
Rohit-rk07 wants to merge 1 commit intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
Author
|
@omsuneri @walterbender please review as it is very important, tests are failing in all PRs due to this issue. This fix prevents GraphicsBlocks.org methods from crashing when parent connections are missing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HeadingBlock.arg,XBlock.arg, andYBlock.argagainst missingblockList/parent connectionsargwith a missingblkTesting
PR Category
Fixes #6179