Skip to content

ci: fail fast when package-lock.json is out of sync#6183

Open
shivv23 wants to merge 1 commit intosugarlabs:masterfrom
shivv23:fix-6168-lockfile-sync-ci
Open

ci: fail fast when package-lock.json is out of sync#6183
shivv23 wants to merge 1 commit intosugarlabs:masterfrom
shivv23:fix-6168-lockfile-sync-ci

Conversation

@shivv23
Copy link

@shivv23 shivv23 commented Mar 9, 2026

Fixes #6168

Summary

  • add a reusable lockfile precheck script at .github/scripts/validate-lockfile-sync.sh
  • run this validation before dependency installation in:
    • pr-cypress-e2e.yml
    • lighthouse-ci.yml
    • pr-jest-tests.yml

Behavior

  • workflows now fail early with a clear message when package-lock.json is out of sync with package.json
  • avoids confusing downstream install failures and points contributors to run npm install and commit the updated lockfile

PR Category

  • Bug Fix
  • Feature
  • Performance
  • Tests
  • Documentation

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

✅ All Jest tests passed! This PR is ready to merge.

@shivv23 shivv23 force-pushed the fix-6168-lockfile-sync-ci branch from 910c508 to 6fa534c Compare March 9, 2026 15:47
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Failed Tests:

GraphicsBlocks.test.js

@github-actions github-actions bot added the tests Adds or updates test coverage label Mar 9, 2026
@shivv23
Copy link
Author

shivv23 commented Mar 9, 2026

All code-side checks are fixed and PR Category check now passes.
Only fork-gated workflows show action_required.
Could a maintainer please click “Approve and run workflows” for this PR?
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Adds or updates test coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Package-lock.json and package.json sync validation needed in CI workflows

1 participant