Skip to content

fix: move typingDiv guard to sendMessage() to prevent chatHistory desync (#6172) #6184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
piyushdotcomm wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Open

fix: move typingDiv guard to sendMessage() to prevent chatHistory desync (#6172) #6184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion js/widgets/reflection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,6 @@ class ReflectionMatrix {
let reply;
// check if message is from user or bot
if (user_query === true) {
if (this.typingDiv) return;
reply = await this.generateBotReply(
message,
this.chatHistory,
Expand Down Expand Up @@ -498,6 +497,9 @@ class ReflectionMatrix {
sendMessage() {
const text = this.input.value.trim();
if (text === "") return;

// Prevent sending while the bot is still processing a previous query
if (this.typingDiv) return;
this.chatHistory.push({
role: "user",
content: text
Expand Down
Loading