Skip to content

fix: prevent TypeError when creating new project from Planet interface #6186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mishtiagrawal02-cloud wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −5
Open

fix: prevent TypeError when creating new project from Planet interface #6186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c38e1d9
fix: prevent TypeError when creating new project from Planet interface
Mar 9, 2026
2e969e9
fix: safely resolve blocks reference in GraphicsBlocks and update sta…
Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions js/blocks/GraphicsBlocks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ function setupGraphicsBlocks(activity) {
* @returns {number} - The heading value.
*/
arg(logo, turtle, blk) {
const connections = activity.blocks.blockList[blk]?.connections;
const connections = activity?.blocks?.blockList?.[blk]?.connections;
const parentId = connections?.[0];
if (
logo.inStatusMatrix &&
Expand Down Expand Up @@ -182,7 +182,8 @@ function setupGraphicsBlocks(activity) {
* @returns {number} - The Y-coordinate value.
*/
arg(logo, turtle, blk) {
const connections = activity.blocks.blockList[blk]?.connections;
const blocks = logo?.activity?.blocks || logo?.blocks || activity?.blocks;
const connections = blocks?.blockList?.[blk]?.connections;
const parentId = connections?.[0];
if (
logo.inStatusMatrix &&
Expand Down Expand Up @@ -268,7 +269,8 @@ function setupGraphicsBlocks(activity) {
* @returns {number} - The X-coordinate value.
*/
arg(logo, turtle, blk) {
const connections = activity.blocks.blockList[blk]?.connections;
const blocks = logo?.activity?.blocks || logo?.blocks || activity?.blocks;
const connections = blocks?.blockList?.[blk]?.connections;
const parentId = connections?.[0];
if (
logo.inStatusMatrix &&
Expand Down
5 changes: 4 additions & 1 deletion js/planetInterface.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,10 @@ class PlanetInterface {
this.newProject = () => {
this.closePlanet();
this.initialiseNewProject();
this.activity._loadStart();
// this.activity._loadStart();
if (this.activity && typeof this.activity._loadStart === "function") {
this.activity._loadStart();
}
this.saveLocally();
};

Expand Down
2 changes: 1 addition & 1 deletion js/widgets/statistics.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class StatsWindow {
this.widgetWindow.getWidgetBody().style.justifyContent = "space-between";
this.widgetWindow.getWidgetBody().style.padding = "0px 2vw";
} else {
this.widgetWindow.getWidgetBody().style.padding = "0px 0px";
this.widgetWindow.getWidgetBody().style.padding = "0px";
}
this.doAnalytics();
};
Expand Down
Loading