feat(a11y): add aria-labels to toolbar icons for screen reader support (#5948)#6187
Open
abhnish wants to merge 5 commits intosugarlabs:masterfrom
Open
feat(a11y): add aria-labels to toolbar icons for screen reader support (#5948)#6187abhnish wants to merge 5 commits intosugarlabs:masterfrom
abhnish wants to merge 5 commits intosugarlabs:masterfrom
Conversation
sugarlabs#5948) - Add aria-label to play, stop, fullscreen, new project, open, save, planet, menu and help toolbar icons in index.html - Add keydown Enter/Space handlers in toolbar.js for play and stop - Addresses WCAG 2.1 AA screen reader accessibility requirements
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #5948 — WCAG 2.1 AA accessibility improvements.
Changes
aria-labelattributes to all main toolbar icons (play, stop,fullscreen, new project, open, save, planet, menu, help) in
index.htmlkeydown(Enter/Space) event handlers intoolbar.jsforplay and stop icons
Why
Without aria-labels, screen readers announced these buttons as just
"button" with no description. This makes each button identifiable
to visually impaired users using screen readers like NVDA or VoiceOver.
Testing
PR Category