Fix TypeError when creating a new project from Planet interface (#6185)#6188
Open
gourijain029-del wants to merge 2 commits intosugarlabs:masterfrom
Open
Fix TypeError when creating a new project from Planet interface (#6185)#6188gourijain029-del wants to merge 2 commits intosugarlabs:masterfrom
gourijain029-del wants to merge 2 commits intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
@gourijain029-del you forgot to add category checks |
Author
added category checks |
Contributor
|
@gourijain029-del hy take a look i drop some comments |
12484f1 to
0969192
Compare
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6185
Description
This PR fixes a runtime error that appeared when clicking the "New Project" ("+") button in the Planet interface.
The bug occurred because
_loadStart()insidejs/activity.jswas previously refactored and renamed tojustLoadStart(), however the corresponding call sequence injs/planetInterface.jshadn't been updated to match the new method name yet.Expected Behavior
Clicking the "New Project" button inside the Planet interface will now start a blank new project smoothly without throwing a
TypeErrorin the console.Changes Made
this.activity._loadStart()withthis.activity.justLoadStart()insidejs/planetInterface.js.js/__tests__/planetInterface.test.jsso that they mock and verifyjustLoadStartinstead of the deprecated_loadStartfunction.PR Category
Checklist